This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Input: Fix webkit autocomplete styles #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adjusts the CSS for Input (and indirectly, Select), to allow for the webkit autocomplete state to render correctly. Previously, the autocomplete styles were overlapping the Input component's "Backdrop" layer (a technique used to render the appearance/border of the component). To resolve this, I've added a 1px padding around the container, which simulates the offset a typical non-backdrop border would provide. With this change, the autocomplete styles no-longer overflow on top of the backdrop layer. This update is purely a CSS change. The only JS changes made were to update the Input component Stories to add an autocomplete example (and to refactor). :clapping:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input: Fix webkit autocomplete styles
Chrome
Safari
This update adjusts the CSS for Input (and indirectly, Select), to allow for
the webkit autocomplete state to render correctly.
Previously, the autocomplete styles were overlapping the Input component's
"Backdrop" layer (a technique used to render the appearance/border of the
component). To resolve this, I've added a 1px padding around the container,
which simulates the offset a typical non-backdrop border would provide.
With this change, the autocomplete styles no-longer overflow on top of
the backdrop layer.
This update is purely a CSS change. The only JS changes made were to update
the Input component Stories to add an autocomplete example (and to refactor).
馃憦
These changes were manually visually tested in Chrome + Safari. Also tested in Firefox for regressions.
Resolves: #100