Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Fix survey issues #1066

Merged
merged 3 commits into from
May 24, 2022
Merged

Fix survey issues #1066

merged 3 commits into from
May 24, 2022

Conversation

jakubjanczyk
Copy link
Collaborator

Problem/Feature

This PR fixes some issues found for Messages survey components:

  • Color of submit button was always blue, it should be using the current theme instead
  • Text for submit button was not truncated
  • The animations/transitions when selecting thumb/face was a bit clunky - I had to delay (optionally) showing confirmation form after selecting an option, so that the animation for option finishes before. I also added some height animation to the form itself for nicer entry

Guidelines

Make sure the pull request:

  • Follows the established folder/file structure
  • Adds unit tests
  • If it is a refactor or change to an existing component, have you verified it won't break existing Cypress tests or have you updated them?
  • Did you verify some accessibility (a11y) basics?
  • Adds/updates stories. Guidelines
  • Adds/updates documentation (ie proptypes) Guidelines
  • Has it been tested in Help Scout's supported browsers?
  • Requests review from designer of the feature
  • Add label (bug? feature?)

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 24, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 570668a
Status: ✅  Deploy successful!
Preview URL: https://e5cd936a.hsds-react.pages.dev

View logs

Copy link
Collaborator

@tinkertrain tinkertrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jakubjanczyk jakubjanczyk merged commit 3b5735b into main May 24, 2022
@jakubjanczyk jakubjanczyk deleted the fix-survey-issues branch May 24, 2022 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants