This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Table: adds the ability to change the table role #1076
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
We add a new table prop
tableRole
which changes therole
attribute of the table element for special cases that require it.When we change this attribute to something other than "table", we also make other attribute changes (in sortable tables)
th
no longer get thearia-sort
attribute setaria-label
attribute on the button inside theth
, that reads "Sorted {columnName} name {order}" for example: "Sorted by name ascending"We also adjust the row border focus from 2px to 3px
And we update all table tests to use testing-library