Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Table: adds the ability to change the table role #1076

Merged
merged 1 commit into from Jun 30, 2022
Merged

Conversation

tinkertrain
Copy link
Collaborator

Feature

We add a new table prop tableRole which changes the role attribute of the table element for special cases that require it.

When we change this attribute to something other than "table", we also make other attribute changes (in sortable tables)

  • th no longer get the aria-sort attribute set
  • Instead we add a aria-label attribute on the button inside the th, that reads "Sorted {columnName} name {order}" for example: "Sorted by name ascending"

We also adjust the row border focus from 2px to 3px
And we update all table tests to use testing-library

@tinkertrain tinkertrain self-assigned this Jun 30, 2022
Copy link
Collaborator

@knicklabs knicklabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @tinkertrain! I'll go ahead and ship this as we discussed in Slack.

@knicklabs knicklabs merged commit e815a30 into main Jun 30, 2022
@knicklabs knicklabs deleted the table-role branch June 30, 2022 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants