This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
SelectDropdown: Add support for value #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update improves the `SelectDropdown` to be able to accept a `value` prop. This adds API parity with `Select` as well as the native HTML select. `value` will be used to find the actual item from the original `items` prop. Both `selectedItem` and `value` is supported for `SelectDropdown`. An enhancement was made to `Dropdown` to add a new `triggerStyle` prop, allowing you to specify inline styles for the Trigger wrapper component.
Pull Request Test Coverage Report for Build 1510
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectDropdown: Add support for value
This update improves the
SelectDropdownto be able to accept avalueprop. This adds API parity withSelectas well as thenative HTML select.
valuewill be used to find the actual item from the originalitemsprop.Both
selectedItemandvalueis supported forSelectDropdown.An enhancement was made to
Dropdownto add a newtriggerStyleprop,allowing you to specify inline styles for the Trigger wrapper
component.
This update has been E2E tested in the main application.