Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Button: Fix hover background-color #570

Merged
merged 1 commit into from Apr 9, 2019
Merged

Conversation

ItsJonQ
Copy link
Contributor

@ItsJonQ ItsJonQ commented Apr 9, 2019

Button: Fix hover background-color

Screen Recording 2019-04-09 at 10 16 AM

This update fixes the Button V2 background-color for the hover state.
It was rendering as undefined due to an inproper key from the style
config.

This update also refactors button.css.js to remove complaints from VS Code (TS).

This update fixes the Button V2 background-color for the hover state.
It was rendering as `undefined` due to an inproper `key` from the style
`config`.
@ItsJonQ ItsJonQ added hot fix 🔥 patch ☝️ To indicate patch version bumps labels Apr 9, 2019
@ItsJonQ ItsJonQ self-assigned this Apr 9, 2019
@ItsJonQ ItsJonQ requested a review from tinkertrain April 9, 2019 14:18
@netlify
Copy link

netlify bot commented Apr 9, 2019

Deploy preview for hsds-react ready!

Built with commit 5905ead

https://deploy-preview-570--hsds-react.netlify.com

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1966

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1962: 0.0%
Covered Lines: 7431
Relevant Lines: 7431

💛 - Coveralls

Copy link
Collaborator

@tinkertrain tinkertrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@ItsJonQ ItsJonQ merged commit 24375af into master Apr 9, 2019
ItsJonQ pushed a commit that referenced this pull request Apr 9, 2019
This update fixes the Button V2 background-color for the hover state.
It was rendering as `undefined` due to an inproper `key` from the style
`config`.
@ItsJonQ ItsJonQ deleted the button-fix-hover-styles branch April 29, 2019 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hot fix 🔥 patch ☝️ To indicate patch version bumps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants