Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

HsApp: Remove helix dependency #584

Merged
merged 2 commits into from
Apr 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@helpscout/hsds-react",
"version": "2.28.1",
"version": "2.28.2-0",
"private": false,
"main": "dist/index.js",
"module": "dist/index.es.js",
Expand Down
2 changes: 1 addition & 1 deletion src/components/HsApp/HsApp.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import Sidenav from './Sidenav'

export interface Props {
children?: any
withInnerWrapper?: boolean
withInnerWrapper: boolean
sidenavComponent?: any
contentComponent?: any
navComponent?: any
Expand Down
15 changes: 7 additions & 8 deletions src/components/HsApp/Nav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,21 @@ import {
} from './HsApp.css'
import Icon from '../Icon'
import Text from '../Text'
import { createSpec, faker } from '@helpscout/helix'

const ItemSpec = createSpec({
id: faker.random.uuid(),
label: faker.company.companyName(),
value: faker.company.companyName(),
})

export interface Props {}

class Nav extends React.PureComponent<Props> {
renderDropdowns() {
const items = [
{ value: 'one', label: 'One' },
{ value: 'two', label: 'Two' },
{ value: 'three', label: 'Three' },
{ value: 'four', label: 'Four' },
]
return ['Mailboxes', 'Docs', 'Reports', 'Manage'].map(d => (
<DropdownUI
key={d}
items={ItemSpec.generate(8)}
items={items}
trigger={
<DropdownTriggerUI>
<Text size="14">{d}</Text>{' '}
Expand Down
2 changes: 1 addition & 1 deletion src/utilities/pkg.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export default {
version: '2.28.1',
version: '2.28.2-0',
}
7 changes: 7 additions & 0 deletions stories/HsApp.stories.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import React from 'react'
import { storiesOf } from '@storybook/react'
import { HsApp } from '../src/index.js'

const stories = storiesOf('HsApp', module)

stories.add('Default', () => <HsApp />)