This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Data Cy: Unwrap Namespaces #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update fixes the `propConnect` data-cy attribute to ensure that any "wrapping" namespaces, typically generated by HOCs, are stripped. For example, `propConnected(Header)` becomes `Header`. `connected(Text)` becomes `Text`. Nested wrappers are also stripped, so `withRouter(connected(Text))` becomes `Text`.
Closed
ItsJonQ
commented
Apr 26, 2019
| ...namespacedProps, | ||
| ...rest, | ||
| className, | ||
| 'data-cy': this.getDataNamespace(), |
There was a problem hiding this comment.
Moved down to override [data-cy] that my exist in ...rest. The this.getDataNamespace() method takes this.props into consideration.
|
Deploy preview for hsds-react ready! Built with commit 870a347 |
|
Deploy preview for hsds-react ready! Built with commit 54bc9c8 |
Pull Request Test Coverage Report for Build 2073
💛 - Coveralls |
ItsJonQ
pushed a commit
that referenced
this pull request
Apr 30, 2019
* Data Cy: Unwrap Namespaces This update fixes the `propConnect` data-cy attribute to ensure that any "wrapping" namespaces, typically generated by HOCs, are stripped. For example, `propConnected(Header)` becomes `Header`. `connected(Text)` becomes `Text`. Nested wrappers are also stripped, so `withRouter(connected(Text))` becomes `Text`. * 2.33.1-1
ItsJonQ
pushed a commit
that referenced
this pull request
Apr 30, 2019
* Data Cy: Unwrap Namespaces This update fixes the `propConnect` data-cy attribute to ensure that any "wrapping" namespaces, typically generated by HOCs, are stripped. For example, `propConnected(Header)` becomes `Header`. `connected(Text)` becomes `Text`. Nested wrappers are also stripped, so `withRouter(connected(Text))` becomes `Text`. * 2.33.1-1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Cy: Unwrap Namespaces
This update fixes the
propConnectdata-cy attribute to ensure that any"wrapping" namespaces, typically generated by HOCs, are stripped.
For example,
propConnected(Header)becomesHeader.connected(Text)becomesText.Nested wrappers are also stripped, so
withRouter(connected(Text))becomesText.Before:
After:
Manually tested by loading the beta build into the app!
Fixes:
#595