This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Input: Improve state focus ring colours #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update improves the `Input`/`Select` focus ring colors to support all of our main UI states, including `error`, `success`, and `warning`. The default `Input` story was enhanced for better UI testing.
|
Deploy preview for hsds-react ready! Built with commit 3066fdc |
Pull Request Test Coverage Report for Build 2088
💛 - Coveralls |
plbabin
reviewed
Apr 29, 2019
| box-shadow: 0 0 0 ${config.focusErrorOutlineWidth}px | ||
| ${config.focusErrorOutlineColor}; | ||
| } | ||
| ${makeFocusStateStyles}; |
There was a problem hiding this comment.
just curious, emotion will execute the function even though there is no direct evocation here? )
plbabin
approved these changes
Apr 29, 2019
That's the plan! One file at a time... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input: Improve state focus ring colours
This update improves the
Input/Selectfocus ring colors to support allof our main UI states, including
error,success, andwarning.The default
Inputstory was enhanced for better UI testing.Input
Select
Resolves: #571