This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the new spec for Customer Name, which is essentially one Field "split" in two inputs, I realized the current structure would not allow for that case to happen, this is an effort to pave the way.
Currently
Editable Fields is composed of 2 components, the main "EditableField" and the "Input", the 2nd handles "interactive" (think input, dropdown) and "static" (what you see when the fields are not active) values and the first one handles state and it is able to render as many "Inputs" as necessary within itself (for multi-value fields).
This works well when you assume that you only have one "interactive" (input) & one "static", but doesn't if you need one "static" to cover 2 inputs for example.
This PR
Here we make the following adjustments:
All in all, here we have quite a bit of work to... have the same as we had before.