Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Fixed prop types on MessageCard image width and height to avoid console error #931

Merged
merged 1 commit into from May 27, 2021

Conversation

jakubjanczyk
Copy link
Collaborator

Problem/Feature

MessageCard image's width and height can be either number or string. The code is prepared for this, but PropTypes have not been allowing numbers. This PR changes PropTypes to allow both.

Write to your heart's content, include:

  • A link to the Figma design in your story (list regularly updated here)
  • A link to the Story(ies) in the description
  • Is there a Jira ticket associated?
  • If useful, add screenshots or videos
  • If useful (and unclear), add a little explanation of why a certain path was taken
  • Instructions on how to test
  • Found any restrictions/limitations? Let us know!

Guidelines

Make sure the pull request:

  • Follows the established folder/file structure
  • Adds unit tests
  • Did you verify some accessibility (a11y) basics?
  • Adds/updates stories. Guidelines
  • Adds/updates documentation (ie proptypes) Guidelines
  • Has it been tested in Help Scout's supported browsers?
  • Requests review from designer of the feature
  • Add label (bug? feature?)

@netlify
Copy link

netlify bot commented May 20, 2021

Deploy Preview for hsds-react ready!

Built with commit 535ef2e

https://deploy-preview-931--hsds-react.netlify.app

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3569

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.191%

Totals Coverage Status
Change from base Build 3566: 0.0%
Covered Lines: 6589
Relevant Lines: 6832

💛 - Coveralls

Copy link
Collaborator

@plbabin plbabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, let's release that only when another PR is merged in master, no need to create a new npm release just for that!

@plbabin plbabin merged commit 5ae9532 into master May 27, 2021
@plbabin plbabin deleted the fix-message-card-prop-types branch May 27, 2021 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants