This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Replaces usage of SelectDropdown in ActionSelect with DropList #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinkertrain
changed the title
|
鉁旓笍 Deploy Preview for hsds-react ready! 馃敤 Explore the source changes: 1c3d4a8 馃攳 Inspect the deploy log: https://app.netlify.com/sites/hsds-react/deploys/60ba47706158190007faadca 馃槑 Browse the preview: https://deploy-preview-933--hsds-react.netlify.app/iframe |
Pull Request Test Coverage Report for Build 3608
馃挍 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dropdown obliteration continues with the last component using it inside HSDS: ActionSelect.
Straightforward refactoring that doesn't change the original interface of
ActionSelectto avoid having to change any usages inside of HSApp or else.馃摴 Original
馃摴 Refactored