Mailman support - Update PR after changes in Master #148
Conversation
janrenz
changed the title
|
Hi Jan, thanks for refactoring. One request for the UI:
|
…o mastermaster * 'mastermaster' of https://github.com/jprberlin/helpy: Use test file from remote master
| <%= f.text_field 'email.imap_server', value: AppSettings['email.imap_server'], label: "IMAP Host" %> | ||
| <%= f.text_field 'email.imap_username', value: AppSettings['email.imap_username'], label: "IMAP Login" %> | ||
| <%= f.password_field 'email.imap_password', value: AppSettings['email.imap_password'], label: "IMAP Password" %> | ||
| </div> | ||
| <%= f.form_group 'email.send_email', label: { text: "Enable Outbound (SMTP) Email" }, class: 'send-email-toggle' do %> |
There was a problem hiding this comment.
Could we also add a toggle and variable for SSL? I am trying to get it working with gmail and had to make that change since they only allow SSL. I am using IMAP...
There was a problem hiding this comment.
Sure. So toggle would set the SSL Flag. What would be the variable? And should SSL be on by default?
There was a problem hiding this comment.
ok, i added a security setting that is either SSL or StartTLS
|
I must be doing something wrong, I am still having troubles getting this working with gmail. When I run the rake task, I see the message being found, but it never shows up in Helpy. Also there is an error line at the top: Any ideas? None of the three messages shows up in my local instance of Helpy and the dev log doesn't show any kind of activity on the message which makes me think that error line may have something to do with it? |
|
I added a default scope, that fixed one issue. I also changed the lookup of users, so that it is not case sensitive. |
|
Nice! I did notice some artifacts from a merge though:
|
|
I saw you added a setting for the port, can you also integrated that into the settings UI/tests? |
|
What do you prefer? Dropdown with common ports or text field? |
|
Hmm thats a good question, probably stay with a text field just in case. |
|
Unfortunately I had to revert this- after a couple days in production on support.helpy.io I noticed a ton of exceptions coming in from the inbound mail handler (we use Sendgrid). On further inspection I noticed the problem was here: Can you look into this and resubmit a PR for further testing? It appears there needs to be some kind of switch here depending on whether the message is coming from |
|
I can also provide a full rails error transcript output if that would be helpful. |
|
OK. It seems like my new code expectes an instance of Mail as its provided by mailin. Griddler seems to handle this proprietary. I will take care. |
Use latest master
Had to create a new PR cause i has some hassles with Git