fix: implement the runtime cache on preparePost functions. #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorbrink
reviewed
Jun 14, 2024
library/Helper/Post.php
Outdated
| @@ -70,6 +84,16 @@ public static function preparePostObjectSingular(\WP_Post $post, $data = null): | |||
| */ | |||
| public static function preparePostObjectArchive(\WP_Post $post, $data = null): object | |||
| { | |||
| $cacheKey = $post->ID . '_' . serialize($data); | |||
There was a problem hiding this comment.
Is it ok for a key to contain all the different characters that may be generated from serialize?
thorbrink
approved these changes
Jun 14, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix, intends to improve performance by blocking and returning already knows results from runtime cache whenever a intentical request is made towards preparePostObject functions.