Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0/feature/refactor react module #27

Merged
merged 13 commits into from
Jan 15, 2021

Conversation

nRamstedt
Copy link
Member

@nRamstedt nRamstedt commented Jan 14, 2021

This PR focuses on applying styles from new styleguide & improving UI/UX

Changelog

  • Add refactored hbg-react library
  • Add loader when fetching data
  • Refactor DatePicker
  • Refactor pagination
  • Refactor dropdown components
  • Refactor button components
  • Refactor input components (search)
  • Refactor EventList & EventItem
  • Refactor preloader

Limitation/Bugs

  • Datepicker does not close when clicking outside datepicker
  • Messy react implementation (no linter, stateful class components because of old react version, old code)

How to test:

  1. Install dependecies & build (npm run build)
  2. Install & activate plugin in wordpress
  3. Go to Events -> Options and set days to 250 and the following api url: https://api.helsingborg.se/event/json/wp/v2
  4. Enable Event Module (in modularity options)(
  5. Create new event module with following settings: All filters enabled & index view

Required dependecies:

  • Styleguide version 0.11.109 or higher, which contains a fix for the o-grid-fit class

@sebastianthulin
Copy link
Member

sebastianthulin commented Jan 14, 2021

  • Cards does not have an equal height. height: 100%; needs to be added to card component.
  • Dropdown selections should not use primary color, make default grey color.
  • Preloader is a bit big.
  • Indication is needed on filters, it may be hard to conceive that they actually are dropdown alternatives.

@sebastianthulin sebastianthulin merged commit 5922072 into 3.0/develop Jan 15, 2021
@nRamstedt nRamstedt deleted the 3.0/feature/refactor-react-module branch November 30, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants