fix: plugin activation crashes site when no options found

helsingborg-stad · Dec 6, 2023 · 63be48e · 63be48e
1 parent cee775a
commit 63be48e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/source/php/WebhooksRegistry/WebhooksRegistry.Test.php b/source/php/WebhooksRegistry/WebhooksRegistry.Test.php
@@ -37,4 +37,16 @@ public function testThatWebhooksGetsCreated()
         $this->assertTrue($webhook->isActive());
         $this->assertEquals(['Content-Type' => 'application/json'], $webhook->getHeaders());
     }
+
+    public function testThatNoExceptionIsThrownWhenNoOptionsAreFound()
+    {
+        WP_Mock::userFunction('get_field')->andReturn(null);
+
+        $webhooksRegistry = new \WebhooksManager\WebhooksRegistry\WebhooksRegistry();
+        $webhooksRegistry->registerWebhooks();
+
+        $webhooks = $webhooksRegistry->getWebhooks();
+        $this->assertIsArray($webhooks);
+        $this->assertCount(0, $webhooks);
+    }
 }
diff --git a/source/php/WebhooksRegistry/WebhooksRegistry.php b/source/php/WebhooksRegistry/WebhooksRegistry.php
@@ -23,7 +23,7 @@ class WebhooksRegistry implements WebhooksRegistryInterface
      */
     public function registerWebhooks(): void
     {
-        $this->webhooksOption = get_field('webhooks', 'option');
+        $this->webhooksOption = get_field('webhooks', 'option') ?? [];
         if (!empty($this->webhooksOption)) {
             $this->registerWebhooksFromOptions();
         }