Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading logging information in opus_express #28

Closed
aarnetalman opened this issue Oct 6, 2021 · 1 comment
Closed

Misleading logging information in opus_express #28

aarnetalman opened this issue Oct 6, 2021 · 1 comment

Comments

@aarnetalman
Copy link
Member

The following lines in opus_express produce misleading logging info.

if not os.path.isfile(archive_path):
print('Skipping %s (no %s-%s)...' % (collection, src_lang, tgt_lang))

The output printed indicates that data for the given language pair is not available in the mentioned collection and that the collection will be skipped, which is not the case.

@miau1
Copy link
Member

miau1 commented Aug 25, 2022

True, the OpusRead command will try to download the files anyway and produce appropriate logging info if the files are actually not found. This message is now removed. Thanks!

@miau1 miau1 closed this as completed Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants