-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blocklist to NameRes #709
Conversation
This is so we can make sure it's loading properly.
This allows the entire blocklist section to be removed by blanking the url.
This allows us to push this branch without breaking ITRB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the github access token is needed by all the instances(ci test, and prod) after this and if its going to be the same across them, maybe we need to save it in values-populated.yaml ,
which is encrypted aswell , and intended to use common values accross envs
Only develop should be on v1.3+, which uses the new JSON format.
This is now hardcoded, but is also set up by the templates.
Thanks for the suggestion, @YaphetKG! I've updated the template to set up a Kubernetes Secret based on the value stored in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We are implementing a Blocklist in Translator at https://github.com/NCATSTranslator/Blocklists, which will consist of a list of CURIEs that must be excluded from NameRes. This PR implements this by modifying the NameRes restore job in three ways:
blocklist.storage
config) to store the Blocklist.blocklist.github_personal_access_token_secret
variable, and whose key is fixed asgithub_personal_access_token
), which will be used to download the Blocklist file if it is in a private GitHub repository.restore.sh
script in to download the Blocklist file (as a text file containing a list of CURIEs, one on each line, as specified by theblocklist.url
config), convert it into a string of double-quoted CURIEs, build a delete query for deleting all of these CURIEs, and then execute it.Also includes: