Support creating custom errors based on the super-error library, add …

…tests, add example
hemerajs · Mar 19, 2017 · e2c4ed2 · e2c4ed2
1 parent 2e03d73
commit e2c4ed2
Show file tree

Hide file tree

Showing 6 changed files with 521 additions and 44 deletions.
diff --git a/examples/custom-errors.js b/examples/custom-errors.js
@@ -0,0 +1,27 @@
+'use strict'
+
+const Hemera = require('./../packages/hemera')
+const nats = require('nats').connect()
+
+const hemera = new Hemera(nats)
+
+hemera.ready(() => {
+  const UnauthorizedError = Hemera.createError('Unauthorized')
+
+  hemera.add({
+    topic: 'math',
+    cmd: 'add'
+  }, function (req, cb) {
+    const err = new UnauthorizedError('Unauthorized action')
+    cb(err)
+  })
+
+  hemera.act({
+    topic: 'math',
+    cmd: 'add',
+    a: 1,
+    b: 2
+  }, function (err, resp) {
+    console.log(err.cause.name, err.cause.message)
+  })
+})
diff --git a/packages/hemera/build/errors.js.map b/packages/hemera/build/errors.js.map
diff --git a/packages/hemera/build/index.js b/packages/hemera/build/index.js
diff --git a/packages/hemera/build/index.js.map b/packages/hemera/build/index.js.map
diff --git a/packages/hemera/lib/index.js b/packages/hemera/lib/index.js
@@ -17,6 +17,7 @@ import _ from 'lodash'
 import Pino from 'pino'
 import OnExit from 'signal-exit'
 import TinySonic from 'tinysonic'
+import SuperError from 'super-error'
 
 import Errors from './errors'
 import Constants from './constants'
@@ -381,6 +382,17 @@ class Hemera extends EventEmitter {
     process.exit(1)
   }
 
+  /**
+   *
+   *
+   * @readonly
+   *
+   * @memberOf Hemera
+   */
+  static createError () {
+    return SuperError.subclass.apply(SuperError, arguments)
+  }
+
   /**
    *
    *
@@ -456,14 +468,19 @@ class Hemera extends EventEmitter {
     function onServerPreResponseHandler (err, value) {
       const self = this
 
-      // check if an error was already catched
+      // check if an error was already wrapped
       if (self._response.error) {
         self.emit('serverResponseError', self._response.error)
         self.log.error(self._response.error)
       } else if (err) { // check for an extension error
-        let error = new Errors.HemeraError(Constants.EXTENSION_ERROR).causedBy(err)
-        self.emit('serverResponseError', error)
-        self._response.error = error
+        if (err instanceof SuperError) {
+          // try to get rootCause then cause and last the thrown error
+          self._response.error = new Errors.HemeraError(Constants.EXTENSION_ERROR).causedBy(err.rootCause || err.cause || err)
+        } else {
+          self._response.error = new Errors.HemeraError(Constants.EXTENSION_ERROR).causedBy(err)
+        }
+
+        self.emit('serverResponseError', self._response.error)
         self.log.error(self._response.error)
       }
 
@@ -530,9 +547,18 @@ class Hemera extends EventEmitter {
       const self = this
 
       if (err) {
-        self._response.error = new Errors.BusinessError(Constants.BUSINESS_ERROR, {
-          pattern: self._pattern
-        }).causedBy(err)
+        if (err instanceof SuperError) {
+          // try to get rootCause then cause and last the thrown error
+          self._response.error = new Errors.BusinessError(Constants.BUSINESS_ERROR, {
+            pattern: self._pattern,
+            app: self._config.name
+          }).causedBy(err.rootCause || err.cause || err)
+        } else {
+          self._response.error = new Errors.BusinessError(Constants.BUSINESS_ERROR, {
+            pattern: self._pattern,
+            app: self._config.name
+          }).causedBy(err)
+        }
 
         return self.finish()
       }
@@ -556,7 +582,13 @@ class Hemera extends EventEmitter {
       const self = this
 
       if (err) {
-        self._response.error = new Errors.HemeraError(Constants.EXTENSION_ERROR).causedBy(err)
+        if (err instanceof SuperError) {
+          // try to get rootCause then cause and last the thrown error
+          self._response.error = new Errors.HemeraError(Constants.EXTENSION_ERROR).causedBy(err.rootCause || err.cause || err)
+        } else {
+          self._response.error = new Errors.HemeraError(Constants.EXTENSION_ERROR).causedBy(err)
+        }
+
         self.log.error(self._response.error)
 
         return self.finish()
@@ -577,9 +609,13 @@ class Hemera extends EventEmitter {
         }, (err) => {
           // middleware error
           if (err) {
-            let error = new Errors.HemeraError(Constants.ADD_MIDDLEWARE_ERROR).causedBy(err)
-            self.log.error(error)
-            self._response.error = error
+            if (err instanceof SuperError) {
+              // try to get rootCause then cause and last the thrown error
+              self._response.error = new Errors.HemeraError(Constants.ADD_MIDDLEWARE_ERROR).causedBy(err.rootCause || err.cause || err)
+            } else {
+              self._response.error = new Errors.HemeraError(Constants.ADD_MIDDLEWARE_ERROR).causedBy(err)
+            }
+            self.log.error(self._response.error)
             return self.finish()
           }
 
@@ -615,9 +651,12 @@ class Hemera extends EventEmitter {
       let self = this
 
       if (err) {
-        let error = new Errors.HemeraError(Constants.EXTENSION_ERROR).causedBy(err)
-        self.log.error(error)
-        self._response.error = error
+        if (err instanceof SuperError) {
+          // try to get rootCause then cause and last the thrown error
+          self._response.error = new Errors.HemeraError(Constants.EXTENSION_ERROR).causedBy(err.rootCause || err.cause || err)
+        } else {
+          self._response.error = new Errors.HemeraError(Constants.EXTENSION_ERROR).causedBy(err)
+        }
 
         return self.finish()
       }