PMAC - 006 - 馃敟 Version 1.0.0 Release 馃敟 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
final changes for version 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ver. 1.0.0 the readme file needs changing. Version number update etc. Also announcing version 1.0. List up features etc. And general cleanup
Remove jg-fisher from readme file
Reduce the number of console prints. Not all of them are needed and can create confusion on users. Only Leave the following information logged to the user.
The goal is to only write verified accounts to a CSV file for easier exportation or usage for different software.
If you successfully get through to the verification process the script is supposed to ask the user if the process was complete. If the user answers with 'yes' then the user will get asked if he/she wants the restart the process of account creation or not. (script then acts concordantly)