Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin is not activated on GitHub Pages #17

Open
oehme opened this issue Apr 7, 2018 · 2 comments
Open

Plugin is not activated on GitHub Pages #17

oehme opened this issue Apr 7, 2018 · 2 comments

Comments

@oehme
Copy link

oehme commented Apr 7, 2018

It seems that GitHub pages no longer sets JEKYLL_ENV. I tried it locally and your plugin works just fine, but when built by GitHub pages, analytics are disabled. Can you reproduce this problem or do you know a workaround?

@oehme oehme changed the title JEKYLL_ENV no longer seems to work JEKYLL_ENV no longer seems to be set on GitHub pages Apr 7, 2018
oehme added a commit to oehme/oehme.github.io that referenced this issue Apr 7, 2018
@oehme oehme changed the title JEKYLL_ENV no longer seems to be set on GitHub pages Plugin is not activated on GitHub Pages Apr 7, 2018
@oehme
Copy link
Author

oehme commented Apr 7, 2018

I tried copy-pasting the plugin and removing the ENV check, but it is still not applied. It seems like GitHub pages is ignoring custom plugins. Have you gotten it working somehow or do you deploy the _site folder yourself?

Edit: I realized that the minima theme supports Google Analytics out of the box, so I just used that instead. I'll leave the issue open in case you want to investigate.

@hendrikschneider
Copy link
Owner

Hi oehme,
it's not working, because it is not whitelisted, look here: #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants