-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Digital Signatures for APIs #132
Comments
The RC does not include the digital signatures. |
Okay, sure. But lets wait till the version 8 is released to avoid conflicts. |
@derjones |
@dantio Thats great news, thank you for implementing this feature! |
@derjones let eBay = new eBayApi({
appId: '...',
certId: '...'
});
const signingKey = await eBay.developer.keyManagement.createSigningKey('ED25519');
// save the JSON somewhere
eBay = new eBayApi({
appId: '...',
certId: '...',
signature: {
jwe: signingKey.jwe,
privateKey: signingKey.privateKey
}
});
const summary = await eBay.sell.finances.sign.getSellerFundsSummary(); |
Yes! Sry that it took so long...
Thank you for implementing this features! |
@derjones |
Released in |
Hey,
starting at 31.01.23 digital signatures are required for specific API calls in EU and UK. (https://developer.ebay.com/develop/guides/digital-signatures-for-apis) The keyManagement API calls are already implemented, but the signatures headers are not added to the specified API calls. Also a createSigningKey request and persisting the keys to a file would be nice.
Ebay created a lib to generate this signatures: https://github.com/ebay/digital-signature-nodejs-sdk
I just saw that you are working on a RC for 8.0.0, do you have plans to add this to this version?
Thanks Jonas
The text was updated successfully, but these errors were encountered: