新しい朦朧の仕様を実装した #1682
Merged
新しい朦朧の仕様を実装した #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habu1010
reviewed
Sep 30, 2021
…he design about PlayerStun so that PlayerStunRank can't be seen from anywhere
Hourier
force-pushed
the
New-Stun-Spec
branch
from
4a9b5c6
to
45d89c1
Compare
|
確認ありがとうございます |
|
is_faint() も合わせて変えたほうがよさそうです。 |
Hourier
force-pushed
the
New-Stun-Spec
branch
from
45d89c1
to
2b75efe
Compare
|
is_faint() の方は忘れてました |
|
確認しました。対応ありがとうざいました。 |
habu1010
requested changes
Sep 30, 2021
src/timed-effect/player-stun.cpp
Outdated
| */ | ||
| bool PlayerStun::is_knocked_out() const | ||
| { | ||
| return this->get_rank() > PlayerStunRank::KNOCKED; |
There was a problem hiding this comment.
ここは最悪値なので「==」が正しいです
修正してforce pushしました
Hourier
force-pushed
the
New-Stun-Spec
branch
from
2b75efe
to
7fc60e3
Compare
|
すみません、過去に組んだ処理がマージミスでどこかへ消えていました |
|
朦朧蓄積ランクに補正をかける処理を追加しました |
habu1010
reviewed
Sep 30, 2021
| auto str = stat_value(player_ptr->stat_cur[A_STR]); | ||
| auto dex = stat_value(player_ptr->stat_cur[A_DEX]); | ||
| auto con = stat_value(player_ptr->stat_cur[A_CON]); | ||
| auto is_powerful_body = str + dex + con > 80; |
There was a problem hiding this comment.
コメントでは80以上となっていますが、実装は80より大きいとなっています。
どちらかを正しい方によせてください。
There was a problem hiding this comment.
コードの方が正しかったのでDoxygenを修正しforce pushしました
ご確認下さい
Hourier
force-pushed
the
New-Stun-Spec
branch
from
b7931d5
to
f0dd51c
Compare
habu1010
approved these changes
Sep 30, 2021
|
確認ありがとうございました！ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
掲題の通りです
今回は、直接打撃に基づく朦朧値の蓄積を緩やかにしました
それ以外 (例：轟音ブレス)は敢えて手つかずにすることで緩やかな蓄積となるように調整しました
手元で確認したところ、「Lv50のちからじまんサイクロプス戦士が宵闇のローブ＋両手に肉体強化の指輪を着ている」というレベルの極端な状況でない限り「昏倒＝行動不能」にはならないようになりました
また、そうであるが故にアイテム使用全般に失率を設けるのも妥当と判断しました
ご確認下さい