message_add 関数をC++機能でリファクタリングする #1026 #1028
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1027 の修正と合わせると、最大81919件のメッセージが保存されるようになり、セーブファイルからメッセージ履歴読み込み時の計算量もO(N log(N))に改善する。
また、人間に理解できるコードになった。
レビューがしやすいように、以下の2つにコミットを分けている。