[Refactor] gen_flagsをFlagGroup<TRG>クラスに変更 #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
メソッドではなくサービス関数で処理するのが相応しいので、 静的メンバ関数にする。 countとatでは2回検索して非効率なので、findで存在を調べて setはfindで見つけたイテレータで処理する。 string_viewに渡す時はstringクラスにする必要が無いので、 生成のコストをカットできるようにconcptrのまま渡す。
|
コラボのマージとリファクタリングしました。 |
habu1010
reviewed
Mar 13, 2021
| @@ -248,7 +248,7 @@ static void analyze_addition(object_type *o_ptr, char *addition) | |||
| { | |||
| artifact_type *a_ptr = &a_info[o_ptr->name1]; | |||
| strcpy(addition, ""); | |||
| if (a_ptr->gen_flags.has(TRG::XTRA_POWER) && a_ptr->gen_flags.has(TRG::XTRA_H_RES)) { | |||
| if (a_ptr->gen_flags.has_any_of({ TRG::XTRA_POWER, TRG::XTRA_H_RES })) { | |||
| strcat(addition, _("能力and耐性", "Ability and Resistance")); | |||
iks3
force-pushed
the
feature-gen-flags-to-flaggroup
branch
from
1bbf6c5
to
b72d9d7
Compare
habu1010
approved these changes
Mar 13, 2021
sikabane-works
added a commit
to sikabane-works/hengband
that referenced
this pull request
Jun 7, 2021
[Add] 古ウルクの士官追加と古ウルクの傭兵調整．
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#253 や #192、#279 の前段階として実装しました。
呪い系エゴが上質確定ドロップでは落ちなくなります。
また、追加能力のフラグを増やしやすくなります。