Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception when $Object.Year is not valid when adding to a UserCustomList #173

Closed
TheUltimateC0der opened this issue Aug 17, 2020 · 0 comments · Fixed by #174
Closed

Exception when $Object.Year is not valid when adding to a UserCustomList #173

TheUltimateC0der opened this issue Aug 17, 2020 · 0 comments · Fixed by #174
Assignees
@henrikfroehling
Labels
Bug Library Module Users Target-Branch: develop Target-Branch: release-1.0.0 v1.0.0 v1.0.2 v1.1.0

Comments

@TheUltimateC0der
Copy link

I noticed that there are a not needed checks, that throw exceptions when a Movie/Show has the Year property not set.

Only the ID (Trakt, Imdb, $Whatever) of the object is needed for adding it to a list (https://trakt.docs.apiary.io/#reference/users/list-items/add-items-to-custom-list)

Trakt.NET/Source/Lib/Trakt.NET/Objects/Post/Users/CustomListItems/Implementations/TraktUserCustomListItemsPostBuilder.cs

Line 49 in 6af5491

if (!movie.Year.HasValue)

Trakt.NET/Source/Lib/Trakt.NET/Objects/Post/Users/CustomListItems/Implementations/TraktUserCustomListItemsPostBuilder.cs

Line 449 in 6af5491

if (!show.Year.HasValue)

@henrikfroehling henrikfroehling self-assigned this Aug 17, 2020
@henrikfroehling henrikfroehling added this to the Version 1.1.0 milestone Aug 17, 2020
henrikfroehling added a commit that referenced this issue Aug 18, 2020
@henrikfroehling
GH-173: Remove checks for valid object year
cadee17
@henrikfroehling henrikfroehling removed this from the Version 1.1.0 milestone Aug 18, 2020
@henrikfroehling henrikfroehling linked a pull request Aug 18, 2020 that will close this issue
Exception when $Object.Year is not valid when adding to a UserCustomList #174
Merged
@TheUltimateC0der TheUltimateC0der mentioned this issue Aug 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrikfroehling henrikfroehling

Labels
Bug Library Module Users Target-Branch: develop Target-Branch: release-1.0.0 v1.0.0 v1.0.2 v1.1.0
Projects
Trakt.NET
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exception when $Object.Year is not valid when adding to a UserCustomList henrikfroehling/Trakt.NET
2 participants
@TheUltimateC0der @henrikfroehling