Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when search text query is empty #64

Closed
TheUltimateC0der opened this issue Dec 18, 2018 · 4 comments
Closed

Exception when search text query is empty #64

TheUltimateC0der opened this issue Dec 18, 2018 · 4 comments

Comments

@TheUltimateC0der
Copy link

The implementation of the API allows the query parameter to be an empty string. However you implemented a check for if query is string.empty and throw an exception if assertion is true.

Reference: https://trakt.docs.apiary.io/#reference/search/text-query/get-text-query-results

@TheUltimateC0der
Copy link
Author

@TheUltimateC0der TheUltimateC0der changed the title Invalid implementation of Search / Text Query / Get text query results Invalid implementation for Search / Text Query / Get text query results Dec 18, 2018
@henrikfroehling henrikfroehling self-assigned this Dec 18, 2018
@henrikfroehling henrikfroehling added this to the Version 1.0.0 Beta 1 milestone Dec 18, 2018
@henrikfroehling henrikfroehling mentioned this issue Dec 18, 2018
60 tasks
@henrikfroehling
Copy link
Owner

In this issue, only the empty string bug will be fixed.
Missing filter support will be fixed in issue #72 .

@henrikfroehling henrikfroehling changed the title Invalid implementation for Search / Text Query / Get text query results Exception when search text query is empty Dec 19, 2018
@TheUltimateC0der
Copy link
Author

if this issue is done, would you mind releasing a new package to nuget ?

@henrikfroehling
Copy link
Owner

Resolved with commit 2ded58e

@TheUltimateC0der I won't release a new package until all 1.0.0-beta release issues are resolved.
But you can get the deployment items (including NuGet package) here: https://dev.azure.com/henrikfroehling/Trakt.NET/_build/results?buildId=151&view=results
Deployment items are always built as if it were a release version.

Alternatively, you can add the MyGet-NuGet feed https://www.myget.org/F/trakt-net/api/v3/index.json to always get the latest CI/CD packages (just look for preview packages - preferably with the highest build number).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants