Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

TypeError: Cannot read property 'lightYellow' of undefined #19

Closed
ELLIOTTCABLE opened this issue May 23, 2017 · 3 comments
Closed

TypeError: Cannot read property 'lightYellow' of undefined #19

ELLIOTTCABLE opened this issue May 23, 2017 · 3 comments

Comments

@ELLIOTTCABLE
Copy link

When installing this plugin, I get the error TypeError: Cannot read property 'lightYellow' of undefined:

screen shot 2017-05-23 at 1 19 24 am

Worse, thereafter, I cannot successfully open Hyper; when trying to, no window appears, and Hyper's menubar never loads:

screen shot 2017-05-23 at 1 21 15 am

If I launch it from the Terminal, I get this on stdout:

> /Applications/Hyper.app/Contents/MacOS/Hyper
running in prod mode
electron will open file:///Applications/Hyper.app/Contents/Resources/app/index.html
Error while loading devtools extensions TypeError: Cannot read property 'lightYellow' of undefined
    at Object.exports.decorateConfig (/Users/ec/.hyper_plugins/node_modules/hyper-tabs-enhanced/index.js:19:37)
    at modules.forEach.plugin (/Applications/Hyper.app/Contents/Resources/app/plugins.js:345:30)
    at Array.forEach (native)
    at decorateObject (/Applications/Hyper.app/Contents/Resources/app/plugins.js:343:11)
    at Object.exports.getDecoratedConfig (/Applications/Hyper.app/Contents/Resources/app/plugins.js:367:10)
    at createWindow (/Applications/Hyper.app/Contents/Resources/app/index.js:107:23)
    at installDevExtensions.then (/Applications/Hyper.app/Contents/Resources/app/index.js:379:3)
@ELLIOTTCABLE
Copy link
Author

Okay, turns out this happens if the existing config doesn't have a colours array (I use a theme, and have deleted all the unchanged-from-default values from my configuration.)

So, it looks like index.js needs to access the default value in Hyper, in the case of the config object missing the defaults!

@ELLIOTTCABLE ELLIOTTCABLE mentioned this issue May 23, 2017
Closed
ELLIOTTCABLE added a commit to ELLIOTTCABLE/System that referenced this issue May 23, 2017
@ELLIOTTCABLE
+ fixing Hyper
154d506 
(Pending henrikruscon/hyper-statusline#50, henrikruscon/hyper-tabs-enhanced#19.)
ELLIOTTCABLE added a commit to ELLIOTTCABLE/System that referenced this issue May 23, 2017
@ELLIOTTCABLE
+ fixing Hyper
e6c3d33 
(Pending henrikruscon/hyper-statusline#50, henrikruscon/hyper-tabs-enhanced#19.)
ELLIOTTCABLE added a commit to ELLIOTTCABLE/System that referenced this issue May 23, 2017
@ELLIOTTCABLE
+ fixing Hyper
0568ee1 
(Pending henrikruscon/hyper-statusline#50, henrikruscon/hyper-tabs-enhanced#19.)
ELLIOTTCABLE added a commit to ELLIOTTCABLE/System that referenced this issue May 23, 2017
@ELLIOTTCABLE
(!! new GUI Mac) Installing Hyper.app!
def3efb 
Ran into a few bugs along the way; see:
 - henrikruscon/hyper-statusline#50
 - henrikruscon/hyper-tabs-enhanced#19
 - brianc/hyperterm-focus-reporting#1
ELLIOTTCABLE added a commit to ELLIOTTCABLE/System that referenced this issue Jun 14, 2017
@ELLIOTTCABLE
+ fixing Hyper
dd59c07 
(Pending henrikruscon/hyper-statusline#50, henrikruscon/hyper-tabs-enhanced#19.)
@henrikruscon
Copy link
Owner

Just fixed this in latest commit ✌️

@ELLIOTTCABLE
Copy link
Author

<3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ELLIOTTCABLE @henrikruscon