Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Revert
  • Loading branch information
HansOlsson committed Aug 16, 2023
1 parent 0caca64 commit 752257e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
3 changes: 1 addition & 2 deletions Modelica/Mechanics/MultiBody/Visualizers/Rectangle.mo
Expand Up @@ -38,8 +38,7 @@ protected
final r_0=frame_a.r_0,
final nu=nu,
final nv=nv,
redeclare function surfaceCharacteristic =
Advanced.SurfaceCharacteristics.rectangle (
redeclare function surfaceCharacteristic = Advanced.SurfaceCharacteristics.rectangle (
lu=length_u, lv=length_v)) if world.enableAnimation and animation
annotation (Placement(transformation(extent={{-20,-10},{0,10}})));
Modelica.Mechanics.MultiBody.Forces.Internal.ZeroForceAndTorque zeroForceAndTorque annotation (Placement(transformation(extent={{-80,-10},{-60,10}})));
Expand Down
7 changes: 3 additions & 4 deletions Modelica/Mechanics/MultiBody/package.mo
Expand Up @@ -145,8 +145,8 @@ model World
annotation (Dialog(tab="Defaults"));

replaceable function gravityAcceleration =
Modelica.Mechanics.MultiBody.Forces.Internal.standardGravityAcceleration
( gravityType=gravityType, g=g*Modelica.Math.Vectors.normalizeWithAssert(n), mu=mu)
Modelica.Mechanics.MultiBody.Forces.Internal.standardGravityAcceleration (
gravityType=gravityType, g=g*Modelica.Math.Vectors.normalizeWithAssert(n), mu=mu)
constrainedby Modelica.Mechanics.MultiBody.Interfaces.partialGravityAcceleration
"Function to compute the gravity acceleration, resolved in world frame"
annotation(choicesAllMatching=true,Dialog(enable=gravityType==
Expand Down Expand Up @@ -335,8 +335,7 @@ protected
final nu=2,
final nv=2,
redeclare function surfaceCharacteristic =
Modelica.Mechanics.MultiBody.Visualizers.Advanced.SurfaceCharacteristics.rectangle
(
Modelica.Mechanics.MultiBody.Visualizers.Advanced.SurfaceCharacteristics.rectangle(
lu=groundLength_u, lv=groundLength_v)) if
enableAnimation and animateGround and gravityType == GravityTypes.UniformGravity;
equation
Expand Down

0 comments on commit 752257e

Please sign in to comment.