Skip to content

Commit

Permalink
Delete unused protected parameters ndim, ndim2 and ndim_pointGravity (m…
Browse files Browse the repository at this point in the history
…odelica#4266)

* Delete unused protected parameters ndim, ndim2 and ndim_pointGravity

* Document changed components in release notes

* Update Modelica/package.mo

Co-authored-by: Thomas Beutlich <modelica@tbeu.de>

---------

Co-authored-by: Harisankar-Allimangalath <144321750+Harisankar-Allimangalath@users.noreply.github.com>
Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
  • Loading branch information
3 people committed Jan 18, 2024
1 parent b540e62 commit e041c72
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
6 changes: 0 additions & 6 deletions Modelica/Mechanics/MultiBody/package.mo
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,6 @@ model World
objects cannot be used.
*/
protected
parameter Integer ndim=if enableAnimation and animateWorld then 1 else 0;
parameter Integer ndim2=if enableAnimation and animateWorld and
axisShowLabels then 1 else 0;

// Parameters to define axes
parameter SI.Length headLength=min(axisLength, axisDiameter*Types.Defaults.
FrameHeadLengthFraction);
Expand Down Expand Up @@ -301,8 +297,6 @@ protected
specularCoefficient=0) if enableAnimation and animateGravity and gravityType == GravityTypes.UniformGravity;

// Point gravity visualization
parameter Integer ndim_pointGravity=if enableAnimation and animateGravity
and gravityType == GravityTypes.UniformGravity then 1 else 0;
Modelica.Mechanics.MultiBody.Visualizers.Advanced.Shape gravitySphere(
shapeType="sphere",
r_shape={-gravitySphereDiameter/2,0,0},
Expand Down
4 changes: 4 additions & 0 deletions Modelica/package.mo
Original file line number Diff line number Diff line change
Expand Up @@ -2530,6 +2530,10 @@ The following <font color=\"blue\"><strong>existing components</strong></font> h
</p>

<table border=\"1\" cellspacing=\"0\" cellpadding=\"2\" style=\"border-collapse:collapse;\">
<tr><td colspan=\"2\"><strong>Mechanics.MultiBody</strong></td></tr>
<tr><td>World</td>
<td>The protected parameters <code>ndim</code>, <code>ndim2</code> and
<code>ndim_pointGravity</code> have been removed.</td></tr>
<tr><td colspan=\"2\"><strong>Mechanics.Rotational.Components</strong></td></tr>
<tr><td>Brake<br>Clutch<br>OneWayClutch</td>
<td>The table interpolation in <code>mu_pos</code> utilizes the interpolation based on <a href=\"modelica://Modelica.Blocks.Types.ExternalCombiTable1D\">ExternalCombiTable1D</a>.<br>The public variable <code>mu0</code> was changed to a protected final parameter.</td></tr>
Expand Down

0 comments on commit e041c72

Please sign in to comment.