Fix installation #37
Merged
Fix installation #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henriqueinonhe
force-pushed
the
fix-installation
branch
from
816a117
to
5ebee6c
Compare
henriqueinonhe
force-pushed
the
fix-installation
branch
3 times, most recently
from
3fd1a7b
to
697f05d
Compare
henriqueinonhe
force-pushed
the
fix-installation
branch
from
697f05d
to
09f9d6b
Compare
henriqueinonhe
force-pushed
the
fix-installation
branch
from
8613843
to
6dd6e85
Compare
henriqueinonhe
force-pushed
the
fix-installation
branch
from
88dfd25
to
4ffd79c
Compare
henriqueinonhe
force-pushed
the
fix-installation
branch
4 times, most recently
from
26c7f41
to
81ed8f9
Compare
henriqueinonhe
force-pushed
the
fix-installation
branch
from
81ed8f9
to
33c897f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of problems were being caused due to a combination of ESM + Windows + Node 20 + TS Node and incompatibilities between all of these things.
After a LOT of trial and error, I've found that the simplest solution would be to get rid of TS Node for the time being, as it relies on unstable Node APIs (which what makes it break when migrating from Node 18 to Node 20 in the first place) to deal with ESM.
So now, to run anything I'm compiling it first using the Typescript compiler itself.
Although this is a little bit annoying, at least it works on all platforms.
Fixes #34 and #35.