Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use XDG directory for configuration #4

Closed
tijn opened this issue Dec 20, 2012 · 3 comments
Closed

Use XDG directory for configuration #4

tijn opened this issue Dec 20, 2012 · 3 comments
Labels
feature

Comments

@tijn
Copy link

tijn commented Dec 20, 2012

At this time the config files are stored in ~/.pplconfig but it would be better if that could be changed to something like ~/.config/ppl/.

In other words: ppl should respect the XDG specs and that would make it really modern and awesome™.

$XDG_CONFIG_HOME defines the base directory relative to which user specific configuration files should be stored. If $XDG_CONFIG_HOME is either not set or empty, a default equal to $HOME/.config should be used.
@henrycatalinismith
Copy link
Owner

Agreed.

I went with ~/.pplconfig to mimic git, but the argument for following XDG is much more rational.

I'll close this issue once this is done, so that anyone else who comes here to suggest this might see it.

henrycatalinismith added a commit that referenced this issue Dec 21, 2012
@henrycatalinismith
Add support for XDG-compatible configuration as requested in issue #4
ea55c1a 
This adds support for configuration via a file called ~/.config/ppl/config if it
exists. Alternatively ~/.config can be whatever the environment value
$XDG_CONFIG_HOME says it should be. XDG config is ignored if a regular
~/.pplconfig exists in order to avoid hassling users who haven't heard of XDG.
@henrycatalinismith
Copy link
Owner

Thanks for this suggestion. I was peripherally aware of XDG and ~/.config already, but what I didn't know was how well organised and well supported it was by now. I might actually start making more use of it myself now that I know!

Anyway, this is supported as of 1.3.0 which is out now. As the commit message (#ea55c1a) says, the XDG-compatible config file is completely ignored if a regular ~/.pplconfig exists, so make sure you definitely either mv or rm that file properly!

@tijn
Copy link
Author

tijn commented Dec 21, 2012

wow, that was quick 👍

henrycatalinismith added a commit that referenced this issue Oct 23, 2017
@henrycatalinismith
Merge pull request #4 from SophieAu/master
4a672bb 
Fixes erroneous mention of email address instead of phone number
henrycatalinismith added a commit that referenced this issue Apr 3, 2021
@henrycatalinismith
Merge pull request #4 from SophieAu/master
19ccef6 
Fixes erroneous mention of email address instead of phone number
henrycatalinismith added a commit that referenced this issue Jan 6, 2022
@henrycatalinismith
Add support for XDG-compatible configuration as requested in issue #4
968c4d5 
This adds support for configuration via a file called ~/.config/ppl/config if it
exists. Alternatively ~/.config can be whatever the environment value
$XDG_CONFIG_HOME says it should be. XDG config is ignored if a regular
~/.pplconfig exists in order to avoid hassling users who haven't heard of XDG.
henrycatalinismith added a commit that referenced this issue Jan 6, 2022
@henrycatalinismith
Merge pull request #4 from SophieAu/master
9f564e7 
Fixes erroneous mention of email address instead of phone number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tijn @henrycatalinismith