Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Code Cleanups #7

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Various Code Cleanups #7

merged 2 commits into from
Nov 20, 2020

Conversation

henrymxu
Copy link
Owner

No description provided.

@henrymxu henrymxu added the enhancement Improvement on current feature label Nov 20, 2020
henrymxu
henrymxu commented Nov 20, 2020
View reviewed changes
src/communication/Responder.ts
@@ -3,10 +3,7 @@ import {Message, MessageEmbed, MessageOptions, TextChannel} from "discord.js"
import {Communicator} from "./Communicator"
import {MessageGenerator} from "./MessageGenerator"

const DEFAULT_EMOJIS = {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wahat 🥇

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not LGTM!

@henrymxu henrymxu merged commit 72f5414 into main Nov 20, 2020
@henrymxu henrymxu deleted the hxu/various-cleanups branch November 20, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wahat Wahat Wahat left review comments

Assignees
No one assigned
Labels
enhancement Improvement on current feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henrymxu @Wahat