Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Merged Streams for Channel Clipping #9

Merged
merged 3 commits into from
Dec 5, 2020
Merged

Implement Merged Streams for Channel Clipping #9

merged 3 commits into from
Dec 5, 2020

Conversation

henrymxu
Copy link
Owner

@henrymxu henrymxu commented Dec 5, 2020

  • Implement audio stream merging by inserting silent buffers when no audio is received
  • This allows users to clip the entire voice channel
  • Clipping a single user still has no silence inserted

@henrymxu henrymxu added the feature Feature implementation label Dec 5, 2020
Wahat
Wahat reviewed Dec 5, 2020
View reviewed changes
src/voice/MergedStream.ts Outdated
buffers.forEach((buffer: Buffer) => {
value += buffer.readInt16LE(i)
})
value = Math.max(-32768, value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constant Values!

@Wahat
Copy link
Contributor

Wahat commented Dec 5, 2020

LGTM!

@henrymxu henrymxu changed the title Implement Merged Streams for Clipping Implement Merged Streams for Channel Clipping Dec 5, 2020
@henrymxu henrymxu merged commit 2ed0e00 into main Dec 5, 2020
@henrymxu henrymxu deleted the hxu/merged-streams branch December 5, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wahat Wahat Wahat approved these changes

Assignees
No one assigned
Labels
feature Feature implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henrymxu @Wahat