Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Close rules window on Escape key #1798

Closed
3 tasks done
eugenesvk opened this issue May 22, 2024 · 4 comments
Closed
3 tasks done

[Feature] Close rules window on Escape key #1798

eugenesvk opened this issue May 22, 2024 · 4 comments
Labels

Comments

@eugenesvk
Copy link

Checklist

  • I have used the search function to see if someone else has already submitted the same feature request.
  • I will describe the problem with as much detail as possible.
  • This issue only contains a request for one single feature, not multiple (related) features.

App version

3.8.2

Problem you are trying to solve

Conveniently closing rules' window with a keyboard

Suggested solution

Make Escape fulfill it's expected role and closed the modal window with a rule

(interestingly enough, it can close the main app's window, but not the "smaller" rules window)

Screenshots / Drawings / Technical details

No response

@henrypp
Copy link
Owner

henrypp commented May 22, 2024

every window already have close on escape

@henrypp henrypp closed this as completed May 22, 2024
@eugenesvk
Copy link
Author

No they don't, check out this video - you can't close the rule modal with Escape right away. Though during more testing I've discovered that Escape starts to work once you alt-tab (or in the video click on the desktop then click on the rule window)

Simplewall.mp4

@henrypp
Copy link
Owner

henrypp commented May 23, 2024

it because it required to select any control, press to any input

@eugenesvk
Copy link
Author

eugenesvk commented May 24, 2024

And it shouldn't, Escape should close the active modal window regardless of any interaction just like it does for the main window or other apps. Why are these modals so special and hard to quit?

By the way, it doesn't work on "any control", if you click on tabs, they apparently don't count as "controls", so Escape doesn't work, which is very weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants