Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupt log encoding #613

Closed
kmm2 opened this issue Feb 12, 2020 · 8 comments
Closed

Corrupt log encoding #613

kmm2 opened this issue Feb 12, 2020 · 8 comments
Labels

Comments

@kmm2
Copy link

kmm2 commented Feb 12, 2020

On Windows 7 the log is corrupt, it looks like Unicode but no app can open it properly. Check the sample simplewall.log

Tested on simplewall-2.4.6 and simplewall-3.1.

OK on Windows 10.

@henrypp
Copy link
Owner

henrypp commented Feb 12, 2020

Not confirmed. Are you sure log file doesn't touched by thirdparty?

@kmm2
Copy link
Author

kmm2 commented Feb 12, 2020

Default installation of simplewall, no third parties.
Windows 7 set to US/Eng location/encoding.

@kmm2
Copy link
Author

kmm2 commented Feb 12, 2020

More observations:

  • if I overwrite the first two 0x00 bytes of the log ("utf-16 le byte order mask") with "{0xFF, 0xFE}", it displays properly.

  • according to your source code, there should be a "csv header" just after the "utf-16 le byte order mask" but I do not see it Win7 nor Win10.

@henrypp
Copy link
Owner

henrypp commented Feb 13, 2020

When you remove log file manual and start SW, byte order mask & csv header adds correctly?

@kmm2
Copy link
Author

kmm2 commented Feb 13, 2020

Yes, it works this way, mask/csv OK, thanks!
Will there be a permanent fix for it in a future SW version?

@henrypp
Copy link
Owner

henrypp commented Feb 13, 2020

I need to know who/what action corrupt the log.

If it SW itself, then fix out. If 3rd-party, then i dont know.

@kmm2
Copy link
Author

kmm2 commented Feb 13, 2020

If you want me to test, modify or run something, please let me know.

Thanks for the best Windows firewall!

@henrypp
Copy link
Owner

henrypp commented Feb 13, 2020

If it happpens again just let me know what steps you do.

@henrypp henrypp added the bug label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants