fix: test assertion for TestOutgoingTLSBadClientCertificate message

henvic · Nov 2, 2023 · 8ccaa9c · 8ccaa9c
1 parent d3bb0e6
commit 8ccaa9c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/client_test.go b/client_test.go
@@ -1451,8 +1451,8 @@ func TestOutgoingTLSBadClientCertificate(t *testing.T) {
 	if _, err = client.Do(req); err == nil || !errors.As(err, &ue) {
 		t.Errorf("got: %v, expected bad certificate error message", err)
 	}
-	want := fmt.Sprintf(golden(t.Name()), ts.URL)
-	if got := buf.String(); got != want {
+	want := fmt.Sprintf(golden(t.Name()), ts.URL, strings.SplitAfter(err.Error(), "remote error: tls: ")[1])
+	if got := buf.String(); !strings.Contains(got, want) {
 		t.Errorf("logged HTTP request %s; want %s", got, want)
 	}
 }

diff --git a/testdata/log.txtar b/testdata/log.txtar
@@ -644,7 +644,7 @@ Hello, world!
 > Host: example.com
 > User-Agent: Robot/0.1 crawler@example.com
 
-* remote error: tls: bad certificate
+* remote error: tls: %s
 -- TestOutgoingTLSInsecureSkipVerify --
 ^\* Request to %s
 \* Skipping TLS verification: connection is susceptible to man-in-the-middle attacks\.