Merge pull request #8 from zdw/master

Change env vars to match Gerrit Trigger Jenkins plugin
heppu · Mar 11, 2020 · ae70663 · ae70663
2 parents 3f57bd8 + 3f91388
commit ae70663
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -17,10 +17,11 @@ Latest version from master can be installed by running: `go get github.com/heppu
 go-review uses following environment variables to access gerrit review server:
 
 - `GERRIT_REVIEW_URL`: required
-- `GERRIT_CHANGE_ID`: required
-- `GERRIT_PATCHSET_REVISION`: required
+- `GERRIT_CHANGE_NUMBER`: required
+- `GERRIT_PATCHSET_NUMBER`: required
 - `GERRIT_USERNAME`: optional
-- `GERRIT_PASSWORD`: optional
+- `GERRIT_PASSWORD`: optional - This is the HTTP Credential, not the password
+  used to login to gerrit.
 
 Behavior can be controlled with following flags:
 

diff --git a/cmd/go-review/main.go b/cmd/go-review/main.go
@@ -30,8 +30,8 @@ func main() {
 	}
 
 	reviewURL := parseEnv("GERRIT_REVIEW_URL", true)
-	changeID := parseEnv("GERRIT_CHANGE_ID", true)
-	revision := parseEnv("GERRIT_PATCHSET_REVISION", true)
+	changeID := parseEnv("GERRIT_CHANGE_NUMBER", true)
+	revision := parseEnv("GERRIT_PATCHSET_NUMBER", true)
 	username := parseEnv("GERRIT_USERNAME", false)
 	password := parseEnv("GERRIT_PASSWORD", false)