Tweak some settings for better Prometheus metrics access. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detiber
reviewed
Mar 7, 2018
scripts/setup-k8s-master.sh.in
Outdated
| controllerManagerExtraArgs: | ||
| address: 0.0.0.0 | ||
| schedulerExtraArgs: | ||
| address: 0.0.0.0 |
There was a problem hiding this comment.
Opening up the metrics endpoints without authentication for these makes me a bit uneasy. I think I would prefer if we held off on these updates until the auth changes land upstream.
There was a problem hiding this comment.
That's fine. I took this change out and left only the kubelet change for now.
These are essentially the changes documented in https://github.com/coreos/prometheus-operator/blob/master/contrib/kube-prometheus/docs/kube-prometheus-on-kubeadm.md. Signed-off-by: Matt Moyer <moyer@heptio.com>
mattmoyer
force-pushed
the
better-metrics-access
branch
from
22eb1ba
to
6c81cbe
Compare
|
@detiber updated, PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are essentially the changes documented in kube-prometheus-on-kubeadm.md. They enable Prometheus running in Kubernetes to scrape container-level metrics from each Kubelet (authenticating with a ServiceAccount token)
and to scrape metrics from.kube-controller-managerandkube-scheduler(anonymously)These have some tradeoffs that we should discuss. Thekube-controller-managerandkube-scheduler--addresschanges mean that they will expose metrics over these endpoints to the whole cluster.These metrics aren't super sensitive but they do give away some context about where the cluster is running, the versions of the components, and some high level picture of what's running in the cluster. I think this is acceptable for most use cases where the Quick Start is appropriate today.There is recent work upstream (kubernetes/kubernetes#59582) that will add authentication options for these endpoints.Update
I dropped the
--addresschanges and left only the Kubelet authentication flag change.