Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregate results information should default to the raw type #820

Closed
johnSchnake opened this issue Aug 1, 2019 · 0 comments · Fixed by #822
Closed

Aggregate results information should default to the raw type #820

johnSchnake opened this issue Aug 1, 2019 · 0 comments · Fixed by #822
Assignees
@johnSchnake
Labels
p0-highest
Milestone
v0.15.1

Comments

@johnSchnake
Copy link
Contributor

What steps did you take and what happened:
Run a custom plugin which doesn't specify the result-format field. You can use sonobuoy gen to copy the e2e plugin definition and clear that field (for one concrete example).

This results in no sonobuoy_results.yaml file being produced and sonobuoy results command being useless for it.

What did you expect to happen:
Without more information to go on, we should assume the raw format, which just means that the server will iterate over the resulting files and save breadcrumbs to them. This would allow the CLI to navigate to those result files easily and report about them.

Environment:

  • Sonobuoy version: v0.15.0 (master)
@johnSchnake johnSchnake self-assigned this Aug 1, 2019
@johnSchnake johnSchnake mentioned this issue Aug 1, 2019
Merged
@johnSchnake johnSchnake added this to the v0.15.1 milestone Aug 1, 2019
johnSchnake added a commit that referenced this issue Aug 1, 2019
@johnSchnake
Default to ResultFormat=raw if unset (#822)
e39cde3 
When unset (or invalid), currently no post-processing is done which
means that users won't find the sonobuoy_results.yaml file.

By defaulting to 'raw' we make users immediately get a benefit from
the post-processing regardless of if they take extra steps to
customize the type/output.

Fixes #820

Signed-off-by: John Schnake <jschnake@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnSchnake johnSchnake

Labels
p0-highest
Projects
None yet
Milestone
v0.15.1
Development

Successfully merging a pull request may close this issue.

Default to ResultFormat=raw if unset
1 participant
@johnSchnake