when restoring a PV, don't remove its spec.storageClassName

[skriss]

Signed-off-by: Steve Kriss krisss@vmware.com

Fixes #1097

I tested this on a couple public clouds and it worked fine.

[nrb]

Did you use this with a custom storage class across providers? For example, regional clusters on GCP require the user to create a custom storage class that represents the zones that the underlying volume is replicated against. This storage class isn't necessarily present in the destination cluster, so the PVs couldn't be scheduled.

[skriss]

StorageClasses themselves are restorable, and are properly prioritized ahead of PVs, so I think in your scenario the user could always restore those StorageClasses first or along with the workload. If a user needs to change the storage class a PV is tagged as, or to remove it entirely, I'd think they would be expected to write a restore plugin to do that.

[carlisia]

lgtm 👍

[nrb]

@skriss Good points, thanks.