Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: upload pod volume backups from *all* pods to obj storage #1739

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

skriss
Copy link
Member

@skriss skriss commented Aug 8, 2019

Signed-off-by: Steve Kriss krisss@vmware.com

Current code is effectively only saving PVB's from the last pod since it's not appending.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh.

@skriss
Copy link
Member Author

skriss commented Aug 8, 2019

Manually testing to confirm fix.

@skriss
Copy link
Member Author

skriss commented Aug 8, 2019

Yep, was able to repro bug with beta.1 and confirm that this fixes it.

@nrb nrb added this to the v1.1 milestone Aug 8, 2019
@nrb nrb merged commit 1429f22 into vmware-tanzu:master Aug 8, 2019
@skriss skriss deleted the fix-pvb-upload-bug branch August 8, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants