Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix booster test #70

Closed
wants to merge 5 commits into from
Closed

Fix booster test #70

wants to merge 5 commits into from

Conversation

darpins
Copy link
Contributor

@darpins darpins commented Jan 19, 2022

add check with $scanMode.
If the $scanMode is booster the greenpassStatusAnonymizer function must return "TEST_NEEDED" status

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DevPGS
Copy link
Collaborator

DevPGS commented Jan 19, 2022

hi @darpins ,
thanks for the commit.
are you testing a Vaccine or a Recovery?

@darpins
Copy link
Contributor Author

darpins commented Jan 19, 2022

hi @DevPGS,
yes i test my personal green pass Vaccine and Recovery with date of September.
Have you a recovery green pass to test?

@DevPGS
Copy link
Collaborator

DevPGS commented Jan 19, 2022

there was an issue with PARTIALLY_VALID and Recovery, the check with status triggered before the BOOSTER check.
Booster mode must return different PARTIALLY_VALID conversion based on Certificate Type:
BOOSTER + Vaccine + PARTIALLY_VALID -> [NOT_VALID] https://github.com/ministero-salute/it-dgc-documentation/blob/master/SCANMODE.md#flussi-vaccinazione
BOOSTER + Recovery + PARTIALLY_VALID -> [TEST_NEEDED] https://github.com/ministero-salute/it-dgc-documentation/blob/master/SCANMODE.md#flussi-guarigione

So, to make it easier to understand, i removed completely the PARTIALLY_VALID status (already deprecated). I close this PR and create a new one without that status.

Thank you @darpins

@DevPGS DevPGS closed this Jan 19, 2022
@DevPGS DevPGS mentioned this pull request Jan 19, 2022
@darpins darpins deleted the fix_booster_test branch January 21, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants