Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Httpd: parsing Apache expressions with quoted strings fails #470

Closed
domcleal opened this issue May 26, 2017 · 0 comments
Closed

Httpd: parsing Apache expressions with quoted strings fails #470

domcleal opened this issue May 26, 2017 · 0 comments
Labels
bug lens

Comments

@domcleal
Copy link
Member

The following valid Apache directive fails to parse:

RequestHeader set X-Forwarded-Proto https expr=(%{HTTP:CF-Visitor}='{"scheme":"https"}')

It seems related to the spacing around quoted strings in the end of the expression. Changing it to this works with Augeas, and I think it's probably still valid for Apache (untested):

RequestHeader set X-Forwarded-Proto https expr=(%{HTTP:CF-Visitor} = '{"scheme":"https"}' )

Reported at certbot/certbot#4734
@domcleal domcleal mentioned this issue May 26, 2017
Closed
@bmw bmw mentioned this issue Jun 8, 2017
Closed
lutter added a commit to lutter/augeas that referenced this issue Sep 27, 2017
@lutter
Httpd: improve handling of arguments in directives
ff6052c 
* handle '>""' properly
* make space between quoted args optional
* do not get confused by quoted strings in bare arguments

Fixes hercules-team#429
Fixes hercules-team#435
Fixes hercules-team#470
lutter added a commit to lutter/augeas that referenced this issue Sep 27, 2017
@lutter
Httpd: improve handling of arguments in directives
f1a8093 
* handle '>""' properly
* make space between quoted args optional
* do not get confused by quoted strings in bare arguments

Fixes hercules-team#429
Fixes hercules-team#435
Fixes hercules-team#470
lutter added a commit to lutter/augeas that referenced this issue Sep 27, 2017
@lutter
Httpd: improve handling of arguments in directives
1954550 
* handle '>""' properly
* make space between quoted args optional
* do not get confused by quoted strings in bare arguments

Fixes hercules-team#429
Fixes hercules-team#435
Fixes hercules-team#470
lutter added a commit to lutter/augeas that referenced this issue Sep 29, 2017
@lutter
Httpd: improve handling of arguments in directives
d72b48a 
* handle '>""' properly
* make space between quoted args optional
* do not get confused by quoted strings in bare arguments

Fixes hercules-team#429
Fixes hercules-team#435
Fixes hercules-team#470
@lutter lutter closed this as completed in e1a8608 Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug lens
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@domcleal