Add :array_append parameter to shellvar type/provider

[raphink]

See http://serverfault.com/a/557032/29328 for original idea.

appending to arrays

shellvar { "GRUB_CMDLINE_LINUX":
  ensure       => present,
  target       => "/etc/default/grub",
  value        => "cgroup_enable=memory",
  array_append => true,
}

will change GRUB_CMDLINE_LINUX="quiet splash" to GRUB_CMDLINE_LINUX="quiet splash cgroup_enable=memory".

shellvar { "GRUB_CMDLINE_LINUX":
  ensure       => present,
  target       => "/etc/default/grub",
  value        => ["quiet", "cgroup_enable=memory"],
  array_append => true,
}

will also change GRUB_CMDLINE_LINUX="quiet splash" to GRUB_CMDLINE_LINUX="quiet splash cgroup_enable=memory".

[domcleal]

This join/split seems unnecessary, could you just do:

is_arr = is.is_a?(Array) ? is : is.split(/\s+/)

[raphink]

Actually, it seems is is always cast as an array, but it might contain either multiple values, or a string of joint values (i.e. ['a', 'b'] or ['a b']), hence this code.

[domcleal]

Yeah, different behaviour for array values or not as we're using array_matching. I'm just concerned that this might not work correctly with actual arrays rather than strings containing spaces. Maybe use is_array? from the provider or something to determine it exactly?

[raphink]

Hmmm. is_array? determines if a path is an array or not. Here, the problem is turning the value into an array, splitting it by values. The fact of using array_append should force considering the value as an array, no?

[domcleal]

Yes, but is_array? might then help you know whether to split the value or not.. without forcing it to join and split again. If an array had whitespace in it, this might split it incorrectly? If is_array? is true, then we can skip joining/splitting.

[raphink]

That's if there is already a value in the tree. Otherwise, there's no way to tell.

[domcleal]

Of course.. but in that case is won't be an array.

[raphink]

Hehe, good point ;-)

[raphink]

Sometimes, the existing value is a string (see the STR_LIST examples in the fixtures), so is_array? will return false, but it should still be treated as an array, and split to compare the values…

[domcleal]

Ah, string array values, fair enough!

[domcleal]

👍 squash and push