-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new parameter to prevent grub-mkconfig being run #59
Conversation
grub_user is a typeBreaking changes to this file MAY impact these 3 modules (near match):kernel_parameter is a typeBreaking changes to this file MAY impact these 14 modules (near match):This module is declared in 6 of 575 indexed public
|
This looks good. Now it only needs some tests 😄 Something similar to https://github.com/hercules-team/augeasproviders_grub/blob/master/spec/unit/puppet/provider/kernel_parameter/grub2_spec.rb#L73, but it should expect to never run when |
Apologies for the delay on this. I had a look at writing some tests but am having some toolchain issues. I've installed the dependencies with |
Are you running |
Ah, no, I was just running |
Yes, please! |
Sorry, not getting very far with this. Tried running |
There's no acceptance tests in this module, all the tests are declared as unit tests, so you run all the tests with |
There actually are acceptance tests and it would be great to run them. The CI can't run them because they require virtual machines and are run through I suggest using PDK to set up an isolated dev environment or RVM or rbenv but not system Ruby. |
Oh my bad, I didn't think we had any acceptance tests in augeasproviders modules. Sorry about that. And I'm guessing docker containers would not be sufficient for grub tests. |
Nope, docker won't work at all for GRUB. Need the real deal :-D. I had to add them due to the complexity of GRUB itself and just being too dangerous to get wrong. |
We used to run beaker on Travis with openstack or AWS nodes, but it's a paid solution. |
Yeah, that's the issue. Without someone to put up a system to run the tests, there's not much that can be done besides run them by hand. |
I'll be able to review this next week if it can wait that long. |
I'm getting failures in beaker with the code that I'll dig into tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After running the acceptance tests, it looks like the :run_mkconfig
parameter also needs to be added to the grub_menuentry
and grub_user
types.
Without this, you will end up with Invalid parameter run_mkconfig(:run_mkconfig)
@cedws Let us know if you need help with the testing. Things are 90% there! |
@trevor-vaughan Thanks very much for this. I will not be able to get to it for a week or so. |
I'll confess interest in this patch... |
@cedws are you still interested in working on this? |
I am, but have quite a lot of things going on at the moment. It's still on my to-do list. Anybody is welcome to pick this up. |
Dear @cedws, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Closes #47.
I'm afraid I don't really know Ruby tooling so I am not sure if the tests pass.