Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[herd-www] aarch64-MTE cat file looks to be out of date on web interface #338

Closed
benbancroft opened this issue Mar 3, 2022 · 2 comments
Closed

Comments

@benbancroft
Copy link
Contributor

The aarch64-MTE.cat file provided by default for the aarch64-MTE profile includes an out of date cat file by default.

This is missing a couple of changes that went back into herd/libdir/aarch64.cat recently.

There may well be other profile cat files which are out of date, I have not personally checked.

This is resulting in the following MTE test showing as allowed, when it looks like it should actually be forbidden:

AArch64 Test
"Amo.LdEorAL PodWWLP CoePT DMB.SYdWRTQ HatQA"
Generator=diyone7 (version 7.56+02~dev)
Prefetch=0:x=F,0:y=W,1:y=F,1:x=T
Com=Co Fr
Orig=Amo.LdEorAL PodWWLP CoePT DMB.SYdWRTQ HatQA
{
0:X0=x:green; 0:X4=y:green;
1:X0=y:red; 1:X1=y:green; 1:X2=x:green;
}
 P0                 | P1            ;
 MOV W2,#1          | STG X0,[X1]   ;
 LDEORAL W2,W1,[X0] | DMB SY        ;
 MOV W3,#1          | LDAPR W3,[X2] ;
 STR W3,[X4]        |               ;
exists ([tag(y)]=:red /\ 0:X1=0 /\ 1:X3=0) /\ ~fault (P0,y)
@maranget
Copy link
Member

maranget commented Mar 4, 2022

Hi @benbancroft, thanks for reporting the problem. We are working on having the default AArch64 model to handle MTE. In other works getting rid of the specific aarch64-MTE cat file.

@maranget
Copy link
Member

maranget commented Mar 5, 2022

The web interface has been updated, aarch64-MTE default model being the standard aarch64.cat model.

Again, thanks for having reported the problem.

@maranget maranget closed this as completed Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants