Cover latest methods

src/Error.php

@@ -90,7 +90,7 @@ public function isOk(): bool
     }
 
     /**
-     * @param Closure(E):void $action
+     * @param Closure(E):mixed $action
      *
      * @return $this
      *
@@ -104,7 +104,7 @@ public function onFailure(Closure $action): static
     }
 
     /**
-     * @param Closure(mixed):void $action
+     * @param Closure(mixed):mixed $action
      *
      * @return $this
      */
@@ -134,7 +134,7 @@ public function or(mixed $value): mixed
 
     public function orDie(int|string $status = null): never
     {
-        if (isset($status)) {
+        if ($status !== null) {
             exit($status);
         }
 

src/Interfaces/Resultlike.php

@@ -42,7 +42,7 @@ public function isOk(): bool;
      * Performs the given `action` on the encapsulated value if this
      * instance is an error. Returns the original instance unchanged.
      *
-     * @param Closure(mixed):void $action
+     * @param Closure(mixed):mixed $action
      *
      * @return $this
      */
@@ -52,7 +52,7 @@ public function onFailure(Closure $action): static;
      * Performs the given `action` on the encapsulated value if this
      * instance is a success. Returns the original instance unchanged.
      *
-     * @param Closure(mixed):void $action
+     * @param Closure(mixed):mixed $action
      *
      * @return $this
      */

src/Ok.php

@@ -99,7 +99,7 @@ public function isOk(): bool
     }
 
     /**
-     * @param Closure(Throwable):void $action
+     * @param Closure(Throwable):mixed $action
      *
      * @return $this
      */
@@ -109,7 +109,7 @@ public function onFailure(Closure $action): static
     }
 
     /**
-     * @param Closure(T):void $action
+     * @param Closure(T):mixed $action
      *
      * @return $this
      *

tests/ErrorTest.php

@@ -223,6 +223,10 @@ function (): void {
                 $this->emptyError->onFailure(fn() => throw new Exception());
             }
         );
+        self::assertSame(
+            $this->emptyError,
+            $this->emptyError->onFailure(function (): void {})
+        );
 
         self::assertSame(
             $this->errorWithException,
@@ -234,6 +238,10 @@ function (): void {
                 $this->errorWithException->onFailure(fn() => throw new Exception());
             }
         );
+        self::assertSame(
+            $this->errorWithException,
+            $this->errorWithException->onFailure(fn() => 42)
+        );
 
         self::assertSame(
             $this->errorWithMessage,
@@ -245,5 +253,9 @@ function (): void {
                 $this->errorWithMessage->onFailure(fn() => throw new Exception());
             }
         );
+        self::assertSame(
+            $this->errorWithMessage,
+            $this->errorWithMessage->onFailure(fn() => 'Smeagol')
+        );
     }
 }

tests/OkTest.php

@@ -77,6 +77,9 @@ public function testBooleanOperations(): void
         self::assertNull($this->emptyOk->orFail());
         self::assertSame(42, $this->okWithValue->orFail());
 
+        self::assertNull($this->emptyOk->orDie());
+        self::assertSame(42, $this->okWithValue->orDie(1));
+
         self::assertNull($this->emptyOk->orThrow(new UnexpectedValueException()));
         self::assertSame(42, $this->okWithValue->orThrow(new UnexpectedValueException()));
 
@@ -149,6 +152,10 @@ function (): void {
             $this->emptyOk,
             $this->emptyOk->onFailure(fn() => throw new Exception())
         );
+        self::assertSame(
+            $this->emptyOk,
+            $this->emptyOk->onSuccess(function (): void {})
+        );
 
         self::assertException(
             Exception::class,
@@ -160,5 +167,9 @@ function (): void {
             $this->okWithValue,
             $this->okWithValue->onFailure(fn() => throw new Exception())
         );
+        self::assertSame(
+            $this->okWithValue,
+            $this->okWithValue->onSuccess(fn() => 42)
+        );
     }
 }