Skip to content

Commit

Permalink
Fix coding style
Browse files Browse the repository at this point in the history
  • Loading branch information
@samuelmaudo
samuelmaudo committed Mar 29, 2024
1 parent a05b299 commit eb50ad9
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 26 deletions.
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"php": "^8.1.17|^8.2.4|^8.3.0"
},
"require-dev": {
"hereldar/coding-style": "^0.1.0",
"hereldar/coding-style": "^0.1.2",
"hereldar/faker-helper": "^0.1.1",
"phpstan/phpstan": "^1.10",
"phpunit/phpunit": "^10.1",
Expand Down
3 changes: 0 additions & 3 deletions src/Error.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,7 @@ public function orDie(int|string|null $status = null): never
* @param Ok<U>|Error<F>|Closure():(Ok<U>|Error<F>) $result
*
* @return Ok<U>|Error<F>
*
* @phpstan-return ($result is Ok ? Ok<U> : ($result is Error ? Error<F> : Ok<U>|Error<F>))
*
* @psalm-return ($result is Ok ? Ok<U> : ($result is Error ? Error<F> : Ok<U>|Error<F>))
*
* @psalm-suppress MoreSpecificImplementedParamType
Expand All @@ -170,7 +168,6 @@ public function orElse(Ok|self|Closure $result): Ok|self

/**
* @throws E|RuntimeException
*
* @phpstan-throws (E is Throwable ? E : RuntimeException)
*
* @psalm-suppress UndefinedDocblockClass
Expand Down
2 changes: 0 additions & 2 deletions src/Ok.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@ public static function empty(): self
* @param Ok<U>|Error<F>|Closure(T):(Ok<U>|Error<F>) $result
*
* @return Ok<U>|Error<F>
*
* @phpstan-return ($result is Ok ? Ok<U> : ($result is Error ? Error<F> : Ok<U>|Error<F>))
*
* @psalm-return ($result is Ok ? Ok<U> : ($result is Error ? Error<F> : Ok<U>|Error<F>))
*
* @psalm-suppress MoreSpecificImplementedParamType
Expand Down
2 changes: 1 addition & 1 deletion tests/ErrorTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public function testBooleanOperationsWithClosures(): void
);

$randomResult = function (): Ok|Error {
return (fake()->boolean())
return (\fake()->boolean())
? Ok::of(true)
: Error::of('false');
};
Expand Down
2 changes: 1 addition & 1 deletion tests/OkTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public function testBooleanOperationsWithClosures(): void
);

$randomResult = function (): Ok|Error {
return (fake()->boolean())
return (\fake()->boolean())
? Ok::of(true)
: Error::of('false');
};
Expand Down
36 changes: 18 additions & 18 deletions tests/ResultTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,17 @@ public function testOfValue(): void
self::assertInstanceOf(Ok::class, $result);
self::assertFalse($result->value());

$value = fake()->integer();
$value = \fake()->integer();
$result = Result::of($value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->float();
$value = \fake()->float();
$result = Result::of($value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->word();
$value = \fake()->word();
$result = Result::of($value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());
Expand All @@ -58,17 +58,17 @@ public function testOfClosure(): void
self::assertInstanceOf(Ok::class, $result);
self::assertFalse($result->value());

$value = fake()->integer();
$value = \fake()->integer();
$result = Result::of(fn () => $value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->float();
$value = \fake()->float();
$result = Result::of(fn () => $value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->word();
$value = \fake()->word();
$result = Result::of(fn () => $value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());
Expand All @@ -89,17 +89,17 @@ public function testFromNullableValue(): void
self::assertInstanceOf(Ok::class, $result);
self::assertFalse($result->value());

$value = fake()->integer();
$value = \fake()->integer();
$result = Result::fromNullable($value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->float();
$value = \fake()->float();
$result = Result::fromNullable($value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->word();
$value = \fake()->word();
$result = Result::fromNullable($value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());
Expand All @@ -115,17 +115,17 @@ public function testFromNullableClosure(): void
self::assertInstanceOf(Ok::class, $result);
self::assertFalse($result->value());

$value = fake()->integer();
$value = \fake()->integer();
$result = Result::fromNullable(fn () => $value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->float();
$value = \fake()->float();
$result = Result::fromNullable(fn () => $value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->word();
$value = \fake()->word();
$result = Result::fromNullable(fn () => $value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());
Expand All @@ -147,17 +147,17 @@ public function testFromFalsableValue(): void
self::assertInstanceOf(Error::class, $result);
self::assertNull($result->value());

$value = fake()->integer();
$value = \fake()->integer();
$result = Result::fromFalsable($value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->float();
$value = \fake()->float();
$result = Result::fromFalsable($value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->word();
$value = \fake()->word();
$result = Result::fromFalsable($value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());
Expand All @@ -173,17 +173,17 @@ public function testFromFalsableClosure(): void
self::assertInstanceOf(Error::class, $result);
self::assertNull($result->value());

$value = fake()->integer();
$value = \fake()->integer();
$result = Result::fromFalsable(fn () => $value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->float();
$value = \fake()->float();
$result = Result::fromFalsable(fn () => $value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());

$value = fake()->word();
$value = \fake()->word();
$result = Result::fromFalsable(fn () => $value);
self::assertInstanceOf(Ok::class, $result);
self::assertSame($value, $result->value());
Expand Down

0 comments on commit eb50ad9

Please sign in to comment.