Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsufficient tests for Python reader and writer. #30

Open
boxdot opened this issue Feb 17, 2018 · 3 comments
Open

Unsufficient tests for Python reader and writer. #30

boxdot opened this issue Feb 17, 2018 · 3 comments
Labels

Comments

@boxdot
Copy link
Collaborator

boxdot commented Feb 17, 2018

Right now, we have generated reader tests (in Python) for the C++ byte reader. The problem is, that they always try to read 1 from the beginning of some data segment, never deeper in the data. In particular, they test that we read correcly with varying bit_size but not varying offset. Note, when reading 1, the bit_size is not really significant.

Generated writer tests are missing completely.

@VeaaC
Copy link
Collaborator

VeaaC commented Feb 19, 2018

Do you mean insufficient python tests? The C++ tests test all offsets with all bit widths, and test the highest bit possible for each.

@boxdot
Copy link
Collaborator Author

boxdot commented Feb 19, 2018

Yes, I mean Python tests.

@boxdot boxdot added the python label Feb 19, 2018
@imagovrn
Copy link
Contributor

imagovrn commented Feb 20, 2018

@boxdot In general I agree with you. However, there are also backward-compatibility tests that are checking both signed and unsigned unaligned values, so it should be safe. This doesn't dismiss the point that we should improve the reader tests.

@imagovrn imagovrn removed their assignment Feb 20, 2018
@boxdot boxdot changed the title Unsufficient tests for C++ reader and writer. Unsufficient tests for Python reader and writer. Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants