Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add mapview padding like on mapbox #176

Closed
Xgamefactory opened this issue Nov 17, 2018 · 16 comments
Closed

please add mapview padding like on mapbox #176

Xgamefactory opened this issue Nov 17, 2018 · 16 comments

Comments

@Xgamefactory
Copy link

it would be nice to have a mapview padding like mapbox did.

Sets the distance from the edges of the map view.

this is really usefull especially for set mapbox bounding box with markers.
here is their opensource mapview.java

https://github.com/mapbox/mapbox-gl-native/blob/1ceea72e6da786537cf3f4038ce56b602c12bfa8/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxMap.java

@nsurgeon
Copy link

Hi
could you please provide more detailed description of functionality you want.
It will be nice to see screenshots (or some UI Mocks) as example.

@Xgamefactory
Copy link
Author

mapbox has a padding feature for mapview. it helps to set bounds with padding smaller to include all markers size. Currently here sdk set bounds method just includes latlngs and markers are not visible in that regiount i mean marker image padding helps to decrease the bounds.

@nsurgeon
Copy link

Seems I can't understand grasp an idea of improvement. I'll rise this question upper: to Product owner and Architects, etc and hopefully we will be able to implement this in a manner you'd like

If you could provide reference to HERE sample code which implements this feature or if you can build simple example - it would be great and, definitely, speed up process and clarify your requirement.

best regards
-Andriy

@starand
Copy link
Contributor

starand commented Nov 23, 2018

@Xgamefactory, could you please provide a screenshot of the needed feature?

@Xgamefactory
Copy link
Author

are you serious ? )

it first screenshot you can see markers not completely visible the mapview bounding box is larger
with setting padding like mapbox does bounding box is reduced and all markers are visible as on second screenshot.

I Hope you will not ask to describe the bounding box heremaps already has it. Also i gave stackoverflow link with similar issues.

image 001

image 002

@nsurgeon
Copy link

thank you for suggesting improvement, we will proceed this with our product manager.

best regards
-andriy

@Xgamefactory
Copy link
Author

any updates ? hope it is clear enough to understand what is padding is and why it is important.

@starand
Copy link
Contributor

starand commented Dec 4, 2018

@Xgamefactory, no updates yet (definitely not in scope of release 3.10).

@Xgamefactory
Copy link
Author

hm. that is very bad (

@starand
Copy link
Contributor

starand commented Dec 4, 2018

@Xgamefactory, right place to ask for new features is TCS. Please talk to them.
Thank you!

@Xgamefactory
Copy link
Author

it is a simple feature what need to have in addition to latlngbounds not an extra.

@starand
Copy link
Contributor

starand commented Dec 6, 2018

ok, management was informed and in case it is approved, we will add the feature in 3.11.
Closing as this is a feature, not an issue.

@starand starand closed this as completed Dec 6, 2018
@starand
Copy link
Contributor

starand commented Jan 4, 2019

@Xgamefactory,
The feature will be implemented in scope of 3.11 release.

@NazarKacharaba
Copy link
Collaborator

@Xgamefactory it is possible to navigate to a set of MapMarkers with predefined viewport size even in pre 3.11 release. See sample here

Method Map.setPadding(...) is added in 3.11, but it should not be used for MapMarkers padding, but rather to define invisible area of the map around MapView(e.g. custom user views that obscure MapView etc.)

@Xgamefactory
Copy link
Author

@NazarKacharaba we will try this example looks like a solution. thanks.

@Xgamefactory
Copy link
Author

it would be nice to have zoomTo method with viewrect in starter sdk too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants